From a73783d17da9552c44702cab6fe5fb16c8ac2b40 Mon Sep 17 00:00:00 2001 From: Juan RP Date: Wed, 15 Apr 2020 13:12:26 +0200 Subject: [PATCH] xbps-src: fix show_pkg_build_depends after af6e1a7e797995f. af6e1a7e797995f introduces dependencies based in subpkgs, but this makes "xbps-src show-build-deps" return cyclic dependencies in some cases, i.e: $ ./xbps-src show-build-deps kirigami2 cmake extra-cmake-modules kcoreaddons kirigami2 qt5 $ This is because `kirigami2-devel` depends on `kirigami2`, thus introducing a cycle. Skip cycles completely, note that "show-build-deps" should not be used to collect deps for cross compilation, because you can't know what type of dependency it is: host or target. --- common/xbps-src/shutils/show.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/common/xbps-src/shutils/show.sh b/common/xbps-src/shutils/show.sh index 22c24ec56f..ff4b94a1c8 100644 --- a/common/xbps-src/shutils/show.sh +++ b/common/xbps-src/shutils/show.sh @@ -68,6 +68,8 @@ show_pkg_build_depends() { # build time deps for f in ${_deps}; do + # ignore dependency on itself + [[ $f == $sourcepkg ]] && continue if [ ! -f $XBPS_SRCPKGDIR/$f/template ]; then msg_error "$pkgver: dependency '$f' does not exist!\n" fi